villebro commented on a change in pull request #14736:
URL: https://github.com/apache/superset/pull/14736#discussion_r636109874
##########
File path: docker/docker-bootstrap.sh
##########
@@ -41,7 +41,7 @@ if [[ "${1}" == "worker" ]]; then
celery worker --app=superset.tasks.celery_app:app -Ofair -l INFO
elif [[ "${1}" == "beat" ]]; then
echo "Starting Celery beat..."
- celery beat --app=superset.tasks.celery_app:app --pidfile
/tmp/celerybeat.pid -l INFO
+ celery beat --app=superset.tasks.celery_app:app --pidfile
/tmp/celerybeat.pid -l INFO -s /app/superset_home/celerybeat-schedule
Review comment:
Should we pick the path to `/app/superset_home` from `${SUPERSET_HOME}`?
##########
File path: Dockerfile
##########
@@ -84,8 +84,8 @@ ENV LANG=C.UTF-8 \
SUPERSET_HOME="/app/superset_home" \
SUPERSET_PORT=8088
-RUN useradd --user-group --no-create-home --no-log-init --shell /bin/bash
superset \
- && mkdir -p ${SUPERSET_HOME} ${PYTHONPATH} \
+RUN useradd --user-group -d ${SUPERSET_HOME} --no-log-init --shell /bin/bash
superset \
+ && mkdir -p ${PYTHONPATH} \
Review comment:
I like this 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
