benjreinhart commented on pull request #14684: URL: https://github.com/apache/superset/pull/14684#issuecomment-845432079
@villebro Thank you for the solid feedback as always! I updated the naming and moved the order of inheritance around per the convention. If you're ok with it, I think my preference would be to hold off on a refactor around the mixin for now. Let me know what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
