hughhhh commented on a change in pull request #14721:
URL: https://github.com/apache/superset/pull/14721#discussion_r636585280
##########
File path: superset/databases/api.py
##########
@@ -909,11 +909,13 @@ def available(self) -> Response:
"preferred": engine_spec.engine in preferred_databases,
}
- if issubclass(engine_spec, BasicParametersMixin):
- payload["parameters"] = engine_spec.parameters_json_schema()
+ if hasattr(engine_spec, "parameters_json_schema") or hasattr(
Review comment:
@betodealmeida let me know if this is good enough of a guard statement
moving forward to make sure we don't call parameters_json_schema for engines we
have implemented yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
