michael-s-molina opened a new pull request #14753:
URL: https://github.com/apache/superset/pull/14753
### SUMMARY
Improves the native filters UI/UX - iteration 2.
- Adds the Basic and Advanced collapse panels
- Moves the column field alongside the dataset field
- Sets `min-width` to the modal to deal with resizing
- Adjusts the borders, padding and margins to the new layout
This work is part of the [Native dashboard filter
project](https://github.com/apache/superset/projects/12)
The bellow items will be handled in the next iterations:
- Split the controllers and organize them in the Basic and Advanced sections
- Add the ability to render a controller dynamically using checkboxes
- Handle the correct tab selection when validating
The bellow iterations are optional but recommended:
- Split the `FiltersConfigForm` into smaller components to make it easier to
read
- Unify the select components to use the AntD one. Currently, we have
different selects with different themes and interactions.
@villebro @rusackas @junlincc
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
https://user-images.githubusercontent.com/70410625/119158335-7ccbf200-ba2c-11eb-99a5-62125d8754fb.mov
https://user-images.githubusercontent.com/70410625/119158355-82c1d300-ba2c-11eb-99e8-c08b8aa55f4b.mov
### TESTING INSTRUCTIONS
1 - Enable native filters feature flag
2 - Enter in a dashboard
3 - Add a native filter
4 - Check the screen
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
