benjreinhart commented on a change in pull request #14684:
URL: https://github.com/apache/superset/pull/14684#discussion_r637128566
##########
File path: superset/app.py
##########
@@ -226,10 +226,12 @@ def init_views(self) -> None:
#
# Setup regular views
#
- if appbuilder.app.config["LOGO_TARGET_PATH"]:
- appbuilder.add_link(
- "Home", label=__("Home"), href="/superset/welcome/",
- )
+ appbuilder.add_link(
+ "Home",
+ label=__("Home"),
+ href="/superset/welcome/",
+ cond=lambda: bool(appbuilder.app.config["LOGO_TARGET_PATH"]),
Review comment:
I'm not sure, but this should maintain parity with the previous code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
