eschutho commented on a change in pull request #14583:
URL: https://github.com/apache/superset/pull/14583#discussion_r637227586
##########
File path: superset-frontend/src/views/CRUD/data/database/types.ts
##########
@@ -52,3 +54,51 @@ export type DatabaseObject = {
allow_csv_upload?: boolean;
extra?: string;
};
+
+export type DatabaseForm = {
+ engine: string;
+ name: string;
+ parameters: {
+ properties: {
+ database: {
+ description: string;
+ type: string;
+ };
+ host: {
+ description: string;
+ type: string;
+ };
+ password: {
+ description: string;
+ nullable: boolean;
+ type: string;
+ };
+ port: {
+ description: string;
+ format: string;
+ type: string;
+ };
+ query: {
+ additionalProperties: {};
+ description: string;
+ type: string;
+ };
+ username: {
+ description: string;
+ nullable: boolean;
+ type: string;
+ };
+ };
+ required: string[];
+ type: string;
+ };
+ preferred: boolean;
+ sqlalchemy_uri_placeholder: string;
+};
+
+// the values should align with the database
+// model enum in superset/superset/models/core.py
+export enum CONFIGURATION_METHOD {
+ SQLALCHEMY_URI = 'sqlalchemy_form',
Review comment:
it shouldn't matter what the key is on the front end, but yeah, maybe
for consistency I'll change it in a future iteration. Thanks for pointing that
out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
