suddjian commented on a change in pull request #14695:
URL: https://github.com/apache/superset/pull/14695#discussion_r637248570
##########
File path: superset-frontend/src/views/CRUD/welcome/ChartTable.tsx
##########
@@ -86,6 +91,13 @@ function ChartTable({
const [chartFilter, setChartFilter] = useState('Mine');
+ useEffect(() => {
+ const filter = getFromLocalStorage('chart', null);
Review comment:
I think we should use more specific names for the local storage keys
than `activity` and `chart` since these names need to be shared globally across
the entire application. Perhaps use `homepage_chart_filter` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
