etr2460 commented on a change in pull request #14756:
URL: https://github.com/apache/superset/pull/14756#discussion_r637261787
##########
File path: superset/jinja_context.py
##########
@@ -297,7 +297,7 @@ def get_filters(self, column: str, remove_filter: bool =
False) -> List[Filter]:
filters: List[Filter] = []
for flt in form_data.get("adhoc_filters", []):
- val: Union[str, List[str]] = flt.get("comparator")
+ val: Union[Any, List[Any]] = flt.get("comparator")
Review comment:
does this need to be `Any`? Maybe there's a more precise type we can use
here? What values are expected for the comparator?
##########
File path: superset/jinja_context.py
##########
@@ -297,7 +297,7 @@ def get_filters(self, column: str, remove_filter: bool =
False) -> List[Filter]:
filters: List[Filter] = []
for flt in form_data.get("adhoc_filters", []):
- val: Union[str, List[str]] = flt.get("comparator")
+ val: Union[Any, List[Any]] = flt.get("comparator")
Review comment:
does this need to be `Any`? Maybe there's a more precise type we can use
here. What values are expected for the comparator?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
