betodealmeida commented on a change in pull request #14721:
URL: https://github.com/apache/superset/pull/14721#discussion_r637448671
##########
File path: superset/databases/commands/validate.py
##########
@@ -81,9 +82,16 @@ def run(self) -> None:
if errors:
raise InvalidParametersError(errors)
+ serialized_encrypted_extra = self._properties.get("encrypted_extra",
"{}")
Review comment:
nit: you can reuse this on line 102
##########
File path: superset/databases/schemas.py
##########
@@ -270,6 +276,12 @@ def build_sqlalchemy_uri(
] = engine_spec.build_sqlalchemy_uri( # type: ignore
parameters
)
+
+ if hasattr(engine_spec, "build_sqlalchemy_uri"):
+ data["sqlalchemy_uri"] = engine_spec.build_sqlalchemy_uri( #
type: ignore
+ parameters, encrypted_extra
+ )
Review comment:
This needs to replace lines 273-278, and inside the `if` block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
