simcha90 commented on a change in pull request #14710:
URL: https://github.com/apache/superset/pull/14710#discussion_r637815852
##########
File path:
superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
##########
@@ -18,31 +18,87 @@
*/
import {
AppSection,
+ DataMask,
ensureIsArray,
+ ExtraFormData,
GenericDataType,
+ JsonObject,
smartDateDetailedFormatter,
t,
tn,
} from '@superset-ui/core';
-import React, { useEffect, useState } from 'react';
+import React, { useEffect, useReducer, useState } from 'react';
import { Select } from 'src/common/components';
-import { FIRST_VALUE, PluginFilterSelectProps, SelectValue } from './types';
+import { debounce } from 'lodash';
+import { SLOW_DEBOUNCE } from 'src/constants';
+import { PluginFilterSelectProps, SelectValue } from './types';
import { StyledSelect, Styles } from '../common';
import { getDataRecordFormatter, getSelectExtraFormData } from '../../utils';
const { Option } = Select;
+const debouncedOwnStateFunc = debounce(
Review comment:
I think we can declare this function inside of component so we can avoid
passing `dispatch` parameter to it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]