geido commented on a change in pull request #14575:
URL: https://github.com/apache/superset/pull/14575#discussion_r637960492
##########
File path:
superset-frontend/src/explore/components/controls/TextControl/index.tsx
##########
@@ -27,6 +27,7 @@ type InputValueType = string | number;
export interface TextControlProps<T extends InputValueType = InputValueType> {
label?: string;
+ name?: string;
Review comment:
It seems that name should not be optional to promote the correct usage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
