hughhhh commented on a change in pull request #14752:
URL: https://github.com/apache/superset/pull/14752#discussion_r638129017
##########
File path: tests/databases/api_tests.py
##########
@@ -1370,9 +1371,11 @@ def test_function_names(self, mock_get_function_names):
@mock.patch("superset.databases.api.get_available_engine_specs")
@mock.patch("superset.databases.api.app")
def test_available(self, app, get_available_engine_specs):
- app.config = {"PREFERRED_DATABASES": ["postgresql"]}
+ app.config = {"PREFERRED_DATABASES": ["postgresql", "mysql",
"redshift"]}
get_available_engine_specs.return_value = [
PostgresEngineSpec,
+ MySQLEngineSpec,
+ RedshiftEngineSpec,
Review comment:
We should have a big query test here as well, make sure you rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
