betodealmeida commented on pull request #14803: URL: https://github.com/apache/superset/pull/14803#issuecomment-848001965
> > The reason for (3) is that if the user doesn't have the default driver installed we can't enable SSL for them. For example, for MySQL the engine spec can only enable it for the default mysqldb driver (see). > > Is SSL the only difference between the default and non default driver? Could we show them the form but not give them the option to turn on ssl (like we do for admins who enforce ssl but the opposite)? Right, but there could potentially be other parameters that are driver-dependent — maybe a MySQL driver uses client certificates instead of username/password — so I think we should only show the form if the default driver is installed. Also, if we show the form when the default driver is not installed, and the user has more than one non-default drivers installed, this raises the problem of which one we should use. Eg, the default driver for MySQL is `mysqldb`, but the user could have `oursql` and `mysqlconnector` installed instead. If we show them the form for MySQL, we would have to choose one of the drivers for them (normally we would use the default driver). I think users in cases like this probably know better, and so they can just the SQLAlchemy URI to configure the DB with a non-default driver. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
