michael-s-molina opened a new pull request #14824:
URL: https://github.com/apache/superset/pull/14824


   ### SUMMARY
   Improves the native filters UI/UX - iteration 3.
   - Splits the controllers and organize them into Basic and Advanced sections
   - Automatically populate and refresh the select options based on the form 
state
   - Removes the Populate and Refresh buttons simplifying the user experience 
   - Expands the Basic section by default
   - Adds the ability to dynamically render a controller using checkboxes
   - Adjusts the tests
   
   This work is part of the [Native dashboard filter 
project](https://github.com/apache/superset/projects/12)
   
   The items below will be handled in the next iterations:
   - Handle the correct tab selection when validating
   - Add a required icon and validation to the controllers when their checkbox 
is checked
   - Add a scroll bar to the left panel
   - Fix left panel layout when the scroll is active
   - Adjust fonts and colors to match the design
   - Make the tabs stick to the top while scrolling
   
   The iterations below are optional but recommended:
   - Split the FiltersConfigForm into smaller components to make it easier to 
read
   - Unify the select components to use the AntD one. Currently, we have 
different selects with different themes and interactions.
   
   @villebro @rusackas @junlincc
   
   @villebro Can you check the sort option to see if we need additional changes 
to it? 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
https://user-images.githubusercontent.com/70410625/119557715-eb83b500-bd76-11eb-8954-34cca8084402.mov
   
   
https://user-images.githubusercontent.com/70410625/119557397-86c85a80-bd76-11eb-97ab-84a578a1dd29.mp4
   
   ### TESTING INSTRUCTIONS
   1 - Enable native filters feature flag
   2 - Enter in a dashboard
   3 - Add a native filter
   4 - Check the screen
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to