kristw commented on issue #6367: [bugfix] EventFlow does not display URL: https://github.com/apache/incubator-superset/pull/6367#issuecomment-437796939 Mapbox and eventflow import external lib in transformProps that are not used anywhere else while the other transformProps are plain js. So it will be better not to include these deps in main bundle and only load them when they are used. The plain js transformprops are tiny and has more benefits to be included in bundle than lazy load tiny file. On Nov 12, 2018, 00:08 -0800, James Finucane <[email protected]>, wrote: > @kristw Before I make the change, what is the benefit of the lazy-load here? This strategy is only taken in Mapbox and EventFlow chart plugins, and it isn't clear to me why (I'm very new to the repo). If there is a benefit, then why not apply to all the chart plugins? If there is no benefit, then why not just be consistent in the method of loading the transformProps? > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or mute the thread.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
