villebro opened a new pull request #14838: URL: https://github.com/apache/superset/pull/14838
### SUMMARY ### BEFORE The indicator would display filters that are outside scope (The "% Rural" chart is outside the scope of both filters). Also note that the filter value shows up on the chart that it's not being applied to: https://user-images.githubusercontent.com/33317356/119633633-9e591f00-be1a-11eb-850c-0a2601e02307.mp4 ### AFTER Now the indicator only shows up for charts that have at least one filter in scope: https://user-images.githubusercontent.com/33317356/119633660-a4e79680-be1a-11eb-9d65-7b476fc97d74.mp4 ### TESTING INSTRUCTIONS Create a dashboard with native filters and exclude a chart from the scope of all filters. Notice how the filter indicator shows up for the chart with all filters showing as "Unset". ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: closes #14807 - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
