zhaoyongjie commented on a change in pull request #14841:
URL: https://github.com/apache/superset/pull/14841#discussion_r639725205
##########
File path: superset-frontend/src/visualizations/FilterBox/FilterBox.jsx
##########
@@ -159,9 +159,10 @@ class FilterBox extends React.PureComponent {
if (Array.isArray(options)) {
vals = options.map(opt => (typeof opt === 'string' ? opt : opt.value));
} else if (options.value) {
- vals = options.value;
+ // must use array member for legacy extra_filters's value
+ vals = [options.value];
Review comment:
If we use `options.value`, the formData in ChartRenderer.js can not be
updated. for the legacy code, this should be the minimum modification for this
issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
