villebro opened a new pull request #14842:
URL: https://github.com/apache/superset/pull/14842


   ### SUMMARY
   Previously, selected values were left in their original place in the native 
select filter. This change emulates that of the GitHub tag component, which 
places the selected values on top after the new values are persisted.
   
   
   
   ### BEFORE
   Previously, the selected values stayed in their original positions after the 
dropdown was collapsed:
   
https://user-images.githubusercontent.com/33317356/119669257-97450780-be40-11eb-909c-34f81518354e.mp4
   
   ### AFTER
   Now the values are reordered when the dropdown is not visible:
   
https://user-images.githubusercontent.com/33317356/119669275-9b712500-be40-11eb-86e8-0ff621da784d.mp4
   
   ### INVERSE SELECTION
   In addition to the reordering, when "Inverse Selection" is active, the 
regular checkmark is replaced with a cross.
   
   Before:
   
![image](https://user-images.githubusercontent.com/33317356/119669135-77154880-be40-11eb-9a99-6485b0fe9eb6.png)
   
   After:
   
![image](https://user-images.githubusercontent.com/33317356/119668882-3ae1e800-be40-11eb-88d7-1655183a1f90.png)
   
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to