rijojoseph07 opened a new pull request #14843:
URL: https://github.com/apache/superset/pull/14843


   ### SUMMARY
   When using authentication with trino, the current behavior is just to modify 
the URL to replace the username which will result in an unauthorized exception. 
This PR will fix this by updating the connection argument with the effective 
user.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   Step 1: Setup database connection to trino with credentials in URL.
   Step 2: Enable impersonation from `Other` option
   Step 3 : Log in with a different user and run the query via SQL lab and you 
will see the principal user as admin and user as the logged-in user in trino UI.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to