kgabryje opened a new pull request #14865: URL: https://github.com/apache/superset/pull/14865
### SUMMARY When a user focuses a native filter, tabs that contain charts in scope of that filter should get highlighted to indicate that the native filter affects contents of those tabs. I didn't highlight active tabs as I thought it would be an overkill, since we also highlight visible charts ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF https://user-images.githubusercontent.com/15073128/119819282-7dfb9400-bef0-11eb-852a-608c6f08af55.mov ### TESTING INSTRUCTIONS 1. Set `DASHBOARD_NATIVE_FILTERS` feature flag to true 2. Create a dashboard with tabs (dashboard level tabs and nested tabs) 3. Create a native filter, play around with scoping 4. Focus on the native filter and verify that tabs that contain charts in scope of that filter are highlighed ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API CC: @villebro @junlincc @graceguo-supercat -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
