villebro opened a new pull request #14873: URL: https://github.com/apache/superset/pull/14873
### SUMMARY Currently setting a select filter to "inverse selection" doesn't visually indicate that the emitted WHERE clause is in fact a "NOT IN" as opposed to the normal "IN". This replaces the normal `CheckOutlined` icon with `StopOutlined` when inverse selection is applied. In addition, a new reserved parameter `label` is introduced on `filterState`, which makes it possible to customize the indicator label. ### BEFORE Currently the dropdown icon for both regular and inverse selection are a checkmark:  The filter indicator also only shows the values as such, without indicating that the values are excluded:  ### AFTER Now the dropdown icon signals that the selected values are excluded:  In addition, the filter indicator text now signals that the selected values are in fact excluded, not included:  ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
