eschutho commented on a change in pull request #14829:
URL: https://github.com/apache/superset/pull/14829#discussion_r641061828
##########
File path:
superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
##########
@@ -34,17 +37,103 @@ export const FormFieldOrder = [
'username',
'password',
'database_name',
+ 'credentials_info',
];
interface FieldPropTypes {
required: boolean;
changeMethods: { onParametersChange: (value: any) => string } & {
onChange: (value: any) => string;
- };
+ } & { onParametersUploadFileChange: (value: any) => string };
validationErrors: JsonObject | null;
getValidation: () => void;
}
+const credentialsInfo = ({
+ required,
+ changeMethods,
+ getValidation,
+ validationErrors,
+}: FieldPropTypes) => {
+ const [uploadOption, setUploadOption] = useState<string>('upload');
+ const [fileToUpload, setFileToUpload] = useState<string>(null);
+ return (
+ <CredentialInfoForm>
+ <>
+ <label className="label-select">
+ How do you want to enter service account credentials?
+ </label>
+ <Select
+ defaultValue={'file'}
+ style={{ width: '100%' }}
+ onChange={option => setUploadOption(option)}
Review comment:
I believe the arrow function here isn't necessary. You should just be
able to pass the `setUploadOption` function since you're passing the same args.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
