michael-s-molina commented on a change in pull request #14872:
URL: https://github.com/apache/superset/pull/14872#discussion_r641570983
##########
File path: superset-frontend/src/CRUD/CollectionTable.tsx
##########
@@ -181,15 +205,75 @@ export default class CRUDCollection extends
React.PureComponent<
}));
}
+ sortColumn(col: string, sort = 0) {
Review comment:
Shouldn't `sort` be a `boolean` indicating if it's ascending or
descending? Do we have more than two possible states? Not sorted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
