eschutho commented on a change in pull request #14829:
URL: https://github.com/apache/superset/pull/14829#discussion_r641649104



##########
File path: 
superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
##########
@@ -259,6 +266,12 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> 
= ({
       }
     } else if (db) {
       // Create
+      if (update.encrypted_extra) {
+        // wrap encrypted_extra in credentials_info
+        update.encrypted_extra = JSON.stringify({
+          credentials_info: JSON.parse(update.encrypted_extra),

Review comment:
       you can do this part in the reducer and keep the db model as close to 
the schema that the api is going to expect.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to