shawnzhu opened a new issue #14904:
URL: https://github.com/apache/superset/issues/14904


   **Is your feature request related to a problem? Please describe.**
   There is no test case to verify changes against `Dockerfile`. E.g.,  #14736 
and #14903 
   
   Which will defer verification of container image to the integration test or 
manual test.
   
   **Describe the solution you'd like**
   I'd like to introduce a new step to the Action workflow 
[`docker.yml`](https://github.com/apache/superset/blob/master/.github/workflows/docker.yml)
 to test built container with container structure test. For example:
   
   
https://github.com/IBM/docker-prestodb/blob/45544ec3b42bd594fee8e84e71f57a612c6c7f11/.github/workflows/test.yml#L28-L31
   
   So that it can show test result and guard changes to `Dockerfile`. e.g.,
   
   ```
   =========================================
   ====== Test file: test_config.yaml ======
   =========================================
   === RUN: File Existence Test: superset-home
   --- PASS
   
   
   =========================================
   ================ RESULTS ================
   =========================================
   Passes:      1
   Failures:    0
   Total tests: 1
   
   PASS
   ```
   
   **Describe alternatives you've considered**
   Document it so that contributors could manually test it.
   
   **Additional context**
   https://github.com/GoogleContainerTools/container-structure-test
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to