shawnzhu commented on a change in pull request #14897:
URL: https://github.com/apache/superset/pull/14897#discussion_r641795859
##########
File path: Dockerfile
##########
@@ -85,6 +85,7 @@ ENV LANG=C.UTF-8 \
SUPERSET_PORT=8088
RUN useradd --user-group -d ${SUPERSET_HOME} --no-log-init --shell /bin/bash
superset \
+ && mkdir -p ${SUPERSET_HOME} \
Review comment:
:point_up: is caused by missing directory `/app`, which will be created
in after this line but really should put before it:
https://github.com/apache/superset/blob/0eb34be78937edc509b6df872bc831d28add675f/Dockerfile#L88
`mkdir -p ${SUPERSET_HOME}` means creating a directory owned by `root`,
which is not expected. I'm with `useradd -m`
see my PR: #14903
https://github.com/shawnzhu/superset/blob/3d7903c68e1e679c4fdcfc2d80220317d86d6540/Dockerfile#L87-L88
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
