geido commented on a change in pull request #14902:
URL: https://github.com/apache/superset/pull/14902#discussion_r641933818
##########
File path: superset-frontend/src/views/CRUD/data/dataset/AddDatasetModal.tsx
##########
@@ -105,12 +100,7 @@ const DatasetModal: FunctionComponent<DatasetModalProps> =
({
onHide={onHide}
primaryButtonName={t('Add')}
show={show}
- title={
- <>
- <StyledIcon name="warning-solid" />
- {t('Add dataset')}
- </>
- }
+ title={<>{t('Add dataset')}</>}
Review comment:
Is the fragment needed here? Can't we just pass a plain string for the
title?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
