hughhhh commented on a change in pull request #14845:
URL: https://github.com/apache/superset/pull/14845#discussion_r643530630



##########
File path: 
superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
##########
@@ -248,10 +247,6 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> 
= ({
     // eslint-disable-next-line @typescript-eslint/no-unused-vars
     const { id, ...update } = db || {};
     if (db?.id) {
-      if (db.sqlalchemy_uri) {

Review comment:
       @eschutho shouldnt we delete this since `sqlalchemy_uri` will always be 
available via GET /databases/<id>




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to