AAfghahi opened a new pull request #14953:
URL: https://github.com/apache/superset/pull/14953


   ### SUMMARY
   This is a small change to isAdmin in ResultSet, which adds an additional 
safeguard. 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   N/A
   
   ### TESTING INSTRUCTIONS
   Go to SQL Editor, choose 100,000 as the amount of results in result 
dropdown. 
   Run a legitimate query as an administrator. 
   
   Your message should be: 
   The number of results displayed is limited to 10000 by the configuration 
DISPLAY_MAX_ROWS. Please add additional limits/filters or download to csv to 
see more rows up to the 100000 limit.
   
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to