andrewbastian opened a new pull request #14956:
URL: https://github.com/apache/superset/pull/14956


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Added `min-height` and `min-width` to **Trash Icons** on _Edit Dataset 
modal's_ 3 tabs which use this Icon. - _metrics_, _columns_, and _calculated 
columns_.
   `min-height` and `min-width` are set to `18px`
   Style added to nested components in `crud.less`
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   **BEFORE:**
   
   
![](https://trello-attachments.s3.amazonaws.com/60adc09bfa7e4d1c94afa8af/60ae99f51746a00fd8e6ac3b/c8dd44ae7510864db102d82874375a41/Clipboard_2021-25-05_at_4.58.11_PM.png)
   **AFTER**
   
   ![Screen Shot 2021-06-02 at 12 42 57 
PM](https://user-images.githubusercontent.com/50464395/120542887-7e88a480-c3a0-11eb-8b49-6269e218296d.png)
   
   
   ### TESTING INSTRUCTIONS
   Attached is a screenshot of developer-tools showing the changes made. The 
_layout box model_ shows that the height and width of the Trash SVG are set to 
18px.
   
   ![Screen Shot 2021-06-02 at 12 42 17 
PM](https://user-images.githubusercontent.com/50464395/120543277-01116400-c3a1-11eb-9ad6-b98d71f5a7ae.png)
   
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to