eschutho commented on a change in pull request #14845:
URL: https://github.com/apache/superset/pull/14845#discussion_r644307993
##########
File path:
superset-frontend/src/views/CRUD/data/database/DatabaseModal/DatabaseConnectionForm.tsx
##########
@@ -179,12 +197,14 @@ const DatabaseConnectionForm = ({
getValidation: () => void;
}) => (
<>
- <StyledFormHeader>
- <h4>Enter the required {name} credentials</h4>
- <p className="helper">
- Need help? Learn more about connecting to {name}.
- </p>
- </StyledFormHeader>
+ {!isEditMode && (
+ <StyledFormHeader>
+ <h4>Enter the required {name} credentials</h4>
+ <p className="helper">
+ Need help? Learn more about connecting to {name}.
+ </p>
+ </StyledFormHeader>
+ )}
Review comment:
you can move the header out to the index file like we did here:
https://github.com/apache/superset/blob/e53983404ef797f0da6e6136f0ea01550d1d56f4/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx#L367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
