eschutho commented on a change in pull request #14845:
URL: https://github.com/apache/superset/pull/14845#discussion_r644341389
##########
File path:
superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
##########
@@ -162,8 +163,6 @@ function dbReducer(
};
case ActionType.fetched:
return {
- engine: trimmedState.engine,
- configuration_method: trimmedState.configuration_method,
Review comment:
ok, then you can move the whole case statement down with
```
case ActionType.dbSelected:
case ActionType.configMethodChange:
```
since the return value is the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
