[GitHub] [superset] eschutho opened a new pull request #14957: create translation function for superset text overrides

[GitBox]

eschutho opened a new pull request #14957:
URL: https://github.com/apache/superset/pull/14957


   ### SUMMARY
   After the recent addition of the superset_text.yml file that allows us to 
add specific text overwrites, there was an ask to make this text translatable. 
This change adds a key to the translation files that matches the key in the 
superset_text.yml file. It is up to the admin of the application to add their 
specific translation to that file on their local working system. I did not 
provide a way for people to overwrite that key, just exposed the key into the 
file. Any other suggestions to that end welcome.
   
   I also added a make command for running translations on development
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   With no overwrite or translation:
   <img width="490" alt="_DEV__Superset" 
src="https://user-images.githubusercontent.com/5186919/120567886-958ebd00-c3c7-11eb-937d-3cf3dd20f192.png";>
   
   With only translation:
   <img width="489" alt="_DEV__Superset" 
src="https://user-images.githubusercontent.com/5186919/120567781-5d877a00-c3c7-11eb-8726-3bafa54c3799.png";>
   
   
   With overwrite text and translation: 
   <img width="499" alt="_DEV__Superset" 
src="https://user-images.githubusercontent.com/5186919/120567571-fe296a00-c3c6-11eb-8eac-9e1216f4e975.png";>
   
   ### TESTING INSTRUCTIONS
   Most importantly we should test that this change didn't introduce 
regressions. Open the database modal window. The text should match the first 
screenshot in this ticket. 
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org