villebro opened a new pull request #14964: URL: https://github.com/apache/superset/pull/14964
### SUMMARY #14933 caused a regression for cascading filters. This was caused by the fact that filters with a parent aren't rendered in the filter tab, causing index referencing to the array of nodes in the portal to fall out of sync. This PR does the following: - does not attempt to render a cascading popover for nodes that have a parent (these will be rendered within the parent's popover) - checks the index for the in scope filters from the unfiltered filter array, as the portal node needs to be referenced by this (not the filtered cascading filter array). ### BEFORE Cascading filters caused an error when rendering the filter tab due to the index being referenced on the unfiltered portal node array didn't exist on the cascade filters array:  ### AFTER Now cascading filters show up as expected ("Continent" is the parent of "Country", while "Country code" is unhierarchical):  ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
