villebro commented on pull request #14966: URL: https://github.com/apache/superset/pull/14966#issuecomment-853928265
> Two issues: > 1 - If I select a parent filter then it filters the child filters. However, if I select the child filters first, and select the parent filter after, the values are inconsistent as shown in the video. Is this a problem? > 2 - There's an error happening when trying to access the filter after updating the filters. This error is not happening on master. 1. I don't think this is a problem, as the value filter supports creating values that don't exist in the query result. But we can potentially consider resetting child values that aren't present when updating the parent. Let's discuss this later. 2. I was able to reproduce this problem on master. Therefore I propose merging this now and following up with a fix for this bug and the bug @zhaoyongjie pointed out (also present on master) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
