AAfghahi commented on a change in pull request #14845:
URL: https://github.com/apache/superset/pull/14845#discussion_r644337032
##########
File path:
superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
##########
@@ -162,8 +163,6 @@ function dbReducer(
};
case ActionType.fetched:
return {
- engine: trimmedState.engine,
- configuration_method: trimmedState.configuration_method,
Review comment:
when trying to edit a database, the trimmed state was returning an empty
object.
##########
File path:
superset-frontend/src/views/CRUD/data/database/DatabaseModal/styles.ts
##########
@@ -85,7 +85,6 @@ export const antDModalNoPaddingStyles = css`
`;
export const formScrollableStyles = (theme: SupersetTheme) => css`
- overflow-y: scroll;
Review comment:
no, this overflow actually creates an inner scroll that doesn't work. We
still need to make the header sticky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
