villebro commented on issue #14977:
URL: https://github.com/apache/superset/issues/14977#issuecomment-854681758
My suggestion would be as follows:
- Reword the subheader "All panels with this column will be affected by this
filter" to "All panels with referencing this dataset will be affected by this
filter"
- Do the following pruning to the scoping tree:
1. Add the certification icon to charts that reference the same dataset
2. Show the charts that are referencing a *different* dataset but
containing the same column name. These would be unchecked by default, but could
be forcefully applied, e.g. in the case where we want to construct a filter
from a small static dimension table but should apply to a large fact table.
This is a common use case, so it should be possible, but not the default
behavior IMO.
3. Hide charts that don't feature the same column name.
A few miscellaneous thoughts:
- Time grain and time column should probably only be applicable to charts
with a dataset that features a temporal column (I'd leave this out of scope for
now).
- We need to figure out a good way to encode this behavior into the
dashboard metadata. Right now I believe we're always recording the excluded
charts in the metadata; AFAIK the "Apply to all panels" option isn't explicitly
recorded in the metadata and separable from the "Apply to specific panels"
option. Let's discuss this more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
