Ceridan opened a new pull request #15013: URL: https://github.com/apache/superset/pull/15013
### SUMMARY We add `is_select_query` method to the `superset/db_engine_specs/base.py` to allow override it in the inherited specs. Reason: We are working on the SQLAlchemy Kusto dialect (Azure Data Explorer) and want to propose the support of this dialect in Superset. The current problem is that KQL (Kusto Query Language) doesn't use "SELECT" keyword for queries, it is started from the table name instead. If we want to allow SQLLabs limits UI component to working properly, we need to have the ability to define which query is essentially the SELECT-query in our db engine spec file. More details in the issue: #15011 ### TESTING INSTRUCTIONS The functionality is still the same. Actually, you may just run any query in the SQLLab and verify that the limit (UI component) is still applying. ### ADDITIONAL INFORMATION - [x] Has associated issue: #15011 - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [x] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
