villebro commented on a change in pull request #14869:
URL: https://github.com/apache/superset/pull/14869#discussion_r646438937
##########
File path: superset-frontend/src/filters/components/Select/controlPanel.ts
##########
@@ -93,7 +93,10 @@ const config: ControlPanelConfig = {
resetConfig: true,
affectsDataMask: true,
renderTrigger: true,
- description: t('Select first item by default'),
+ requiredFirst: true,
+ description: t(
+ 'Select first item by default (requires repopulate Default
Value if column field changed)',
Review comment:
I think the text in parenthesis can be replaced with that above (we
don't need to repopulate Default Value anymore).
##########
File path: superset-frontend/src/filters/components/Select/controlPanel.ts
##########
@@ -78,7 +78,7 @@ const config: ControlPanelConfig = {
renderTrigger: true,
description: t(
'User must select a value for this filter when filter is in
single select mode. ' +
- 'If selection is empty, an always false filter is emitted.',
+ 'If selection is empty, an always false filter is emitted
(when using this option, default value can’t be set)',
Review comment:
I don't think this option needs to be updated - did you mean to update
`defaultToFirstItem` below?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
