simcha90 commented on a change in pull request #15012:
URL: https://github.com/apache/superset/pull/15012#discussion_r646447286
##########
File path:
superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
##########
@@ -109,6 +109,7 @@ export default function PluginFilterSelect(props:
PluginFilterSelectProps) {
} = formData;
const groupby = ensureIsArray<string>(formData.groupby);
const [col] = groupby;
+ const [initialColtypeMap] = useState(coltypeMap);
Review comment:
I'm not sure if this proposal will be rellevant, but may be it can make
sense instead of split state to different places we can control calls of
`setDataMask` hook, for example - not call it if doesn't have filled own state
or stuff like that, because if we will have some more logic for own state we
can get same issue, or may be I wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
