[GitHub] [superset] eschutho opened a new pull request #15031: fix: display all metric results in editor

[GitBox]

eschutho opened a new pull request #15031:
URL: https://github.com/apache/superset/pull/15031


   ### SUMMARY
   In the dataset editor, the certified_by, certification_details, and warning 
fields weren't populated with the saved values. 
   This fixes that issue, adds the values into the proper fields and ensures 
that the warning properly shows up. 
   
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   before: 
   <img width="794" alt="Screenshot_6_7_21__5_51_PM" 
src="https://user-images.githubusercontent.com/5186919/121105652-58586f80-c7b9-11eb-8336-ff8737544ecf.png";>
   Fields were empty even though we had previously saved values there. 
   
   
   after: 
   Fields are now populated and the warning is displayed:
   <img width="801" alt="_DEV__Superset" 
src="https://user-images.githubusercontent.com/5186919/121105714-758d3e00-c7b9-11eb-873f-bd747d5cd60d.png";>
   
   <img width="867" alt="_DEV__Superset" 
src="https://user-images.githubusercontent.com/5186919/121105696-6e663000-c7b9-11eb-8bb6-85170bf03492.png";>
   
   
   ### TESTING INSTRUCTIONS
   Open the dataset edit modal, select a metric, expand the field and add some 
values to certified_by, certification_details, and warning fields. Save, and 
reopen the edit dialogue. The values should be there and the warning should 
show up next to the row.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org