villebro commented on pull request #14449: URL: https://github.com/apache/superset/pull/14449#issuecomment-856634339
> Yeah I agree that this probably belongs in a separate form. Just went in this direction because creating a new form would mean that we'd effectively be abandoning #13834. I'll go ahead and get started working on a new form for `parquet/directory/zip` unless @junlincc @srinify @Steejay have any ideas on how to better consolidate these forms. I believe `wtforms` has a `MultipleFileField` class that should allow us to upload entire directories. We can also introduce this change to the `CsvToDatabaseForm` so users can upload multiple CSVs at a time. I think we'll end up consolidating all upload forms into one at some point, but it probably won't happen just yet. So I personally vote for keeping these separate to avoid making one huge form that doesn't really specifically apply to any one format. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
