rusackas commented on a change in pull request #15017:
URL: https://github.com/apache/superset/pull/15017#discussion_r647783110
##########
File path:
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
##########
@@ -180,8 +182,8 @@ const StyledTabs = styled(Tabs)`
const StyledAsterisk = styled.span`
color: ${({ theme }) => theme.colors.error.base};
- font-family: SimSun, sans-serif;
- margin-right: ${({ theme }) => theme.gridUnit - 1}px;
+ font-size: ${({ theme }) => theme.typography.sizes.s}px;
+ margin-left: ${({ theme }) => theme.gridUnit - 1}px;
Review comment:
nit/question: not sure by looking exactly where this applies, but based
on a hunch from the code, it might be a use case for an `em` rather than a
gridUnit, or perhaps a `transform: translateX(-100%);` - just to tie the
positioning of the asterisk to the content itself, rather than to the gridUnit,
which _could_ change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
