villebro edited a comment on pull request #15015:
URL: https://github.com/apache/superset/pull/15015#issuecomment-857412274


   @junlincc it's applying fine for me:
   
![image](https://user-images.githubusercontent.com/33317356/121302682-b775cb80-c902-11eb-96e8-89b3cde6cee8.png)
   
   It appears that the COVID dataset doesn't have a temporal column. Which 
raises the question, we should probably not show a time filter (or time column 
filter for that matter) if there are no temporal columns available in the 
target dataset. However, this same problem applies to Filter Box as well, so I 
propose leaving that to a later PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to