AAfghahi opened a new pull request #15064:
URL: https://github.com/apache/superset/pull/15064


   ### SUMMARY
   A. cosmetic change to the Query History tab in SQL Lab caused some new 
statuses to be seen. They were causing errors for the Icon images that we have 
set up. 
   
   This PR adds the 'fetching' status into QueryStatus for frontend and into 
the backend QueryStatus enum as well. Furthermore, it creates a config called 
'error' in the frontend for any status that does not exist. This will hopefully 
allow for the users to continue using sql lab, but also make an engineer aware 
that the status is new and needs to be added. 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   ![Screen Shot 2021-06-09 at 11 04 33 
AM](https://user-images.githubusercontent.com/48933336/121382318-78507600-c914-11eb-8f15-f865b2782289.png)
   
   I don't have an unknown status but this is to show that query history still 
renders correctly. 
   
   ### TESTING INSTRUCTIONS
   Go to Sql Lab
   Run some queries
   check query history
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to