eschutho opened a new pull request #15069: URL: https://github.com/apache/superset/pull/15069
### SUMMARY I noticed while testing that the markdown metric field isn't updating properly. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF After: https://user-images.githubusercontent.com/5186919/121429307-9c6b8180-c92b-11eb-84ba-5faceb57dbe8.mov ### TESTING INSTRUCTIONS It's difficult to write any kind of tests for the ace editor when looking at value because it always renders "xxx". Something we can try to figure out in the future. In the meantime I added more tests around editing the other metrics. Manual testing: click to edit a dataset, go to metrics, and try to add some test in the markdown field. It should show the text. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
