etr2460 opened a new pull request #15073: URL: https://github.com/apache/superset/pull/15073
### SUMMARY Pulls in the fix here: Tooltips on nvd3 charts are buggy on dashboards, because if you hover over a chart before the rest of them load, the tooltips that have already been hovered on before disappear. This was because the migration to emotion added an extra div in between the chart container and the nvd3 chart, so we couldn't properly manage that chart's tooltips. This fixes the bug by searching for the chart container all the way up the dom to get the proper chart id. ### TESTING INSTRUCTIONS Sync code to superset, load a dashboard with nvd3 charts, hover over a chart to see the tooltip, force refresh a different nvd3 chart, see the first tooltip again after the second chart reloads. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API to: @ktmud @pkdotson @graceguo-supercat -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
