eschutho commented on a change in pull request #15054:
URL: https://github.com/apache/superset/pull/15054#discussion_r649333566
##########
File path:
superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
##########
@@ -247,6 +287,16 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps>
= ({
// don't pass parameters if using the sqlalchemy uri
delete update.parameters;
}
+
+ // // Structure extra_json
+ // const extraValuesStructured = {
+ // ...extraValues,
+ // ...db?.extra_json,
+ // };
+
+ // Add values back to extra field
+ update.extra = JSON.stringify(db?.extra_json, null, ' ');
Review comment:
what about the idea to store this in the `db` object as a string and
then parse it out in the extraOptions component? So you don't have to
manipulate anything here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
