[GitHub] [superset] eschutho opened a new pull request #15108: fix: add another wait for chart element

[GitBox]

eschutho opened a new pull request #15108:
URL: https://github.com/apache/superset/pull/15108


   ### SUMMARY
   Some dashboard reports were being generated with blank charts. Although we 
wait for the loading element to be removed from the page before taking the 
screenshot, there was still an instance where the chart was rendering nothing 
and hadn't yet been updated. I added another check to make sure that the 
"slice_container" had a value if it exists. 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before: 
   <img width="1062" 
alt="_Report__FOO__USA_Births_Names_-_elizandwolf_gmail_com_-_Gmail" 
src="https://user-images.githubusercontent.com/5186919/121613292-00b44100-ca11-11eb-8032-5be3f1e59970.png";>
   
   
   After:
   <img width="1043" 
alt="_Report__test_test__USA_Births_Names_-_elizandwolf_gmail_com_-_Gmail" 
src="https://user-images.githubusercontent.com/5186919/121613249-eed29e00-ca10-11eb-80e4-4edbd3bb308d.png";>
   
   
   ### TESTING INSTRUCTIONS
   I tested this on dashboard reports, but we should also thoroughly test on 
other report types. 
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org