pkdotson commented on a change in pull request #14823:
URL: https://github.com/apache/superset/pull/14823#discussion_r650251576
##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
##########
@@ -246,7 +254,8 @@ export default function ActivityTable({
);
},
);
- if (loadingState && !editedObjs) {
+
+ if ((loadingState && !editedObjs) || loadedCount !== 3) {
Review comment:
Yep makes sense
##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
##########
@@ -68,6 +75,7 @@ interface ActivityProps {
activeChild: string;
setActiveChild: (arg0: string) => void;
activityData: ActivityData;
+ loadedCount: number;
Review comment:
this is a number that is used to determine if all the api calls have
finished.
##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
##########
@@ -246,7 +252,8 @@ export default function ActivityTable({
);
},
);
- if (loadingState && !editedObjs) {
+
+ if ((loadingState && !editedObjs) || loadedCount < 3) {
Review comment:
done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
